Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf(trie): init hashed storage only on existing **changed** slots #12980

Merged
merged 1 commit into from
Nov 28, 2024

Conversation

rkrasiuk
Copy link
Member

Description

Small perf bug - we should initialize hashed storage only if account was destroyed or it has any changed slots.

@rkrasiuk rkrasiuk added C-perf A change motivated by improving speed, memory usage or disk footprint A-trie Related to Merkle Patricia Trie implementation labels Nov 28, 2024
Copy link
Member

@fgimenez fgimenez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good catch

@rkrasiuk rkrasiuk force-pushed the rkrasiuk/trie-init-hashed-storage-from-changed branch from 4b47648 to 8677d14 Compare November 28, 2024 18:24
@rkrasiuk rkrasiuk enabled auto-merge November 28, 2024 18:24
@rkrasiuk rkrasiuk added this pull request to the merge queue Nov 28, 2024
Merged via the queue into main with commit da53d76 Nov 28, 2024
41 checks passed
@rkrasiuk rkrasiuk deleted the rkrasiuk/trie-init-hashed-storage-from-changed branch November 28, 2024 18:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-trie Related to Merkle Patricia Trie implementation C-perf A change motivated by improving speed, memory usage or disk footprint
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants